New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A question about the different residual module from original implementation #580

Open

ethanyanjiali opened this issue Jan 10, 2020 · 0 comments

ethanyanjiali commented Jan 10, 2020 •

edited

Loading

Hi Xingyi,

Thanks for contributing such great code.

As we can see from the initial implementation of Hourglass-104, they use a pre-activation version of residual module and put BN and ReLU before Conv layer:
https://github.com/princeton-vl/pose-hg-train/blob/master/src/models/layers/Residual.lua#L8

And in your version, it seems going back to the vanilla version where Conv layer followed by ReLU and BN:
https://github.com/xingyizhou/CenterNet/blob/master/src/lib/models/networks/large_hourglass.py#L65

Besides, your Hourglass residual module has one less conv layer compared with the original implementation

Could you share some thoughts around this change? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment