Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some questions about the code. #751

Open
domef opened this issue Jun 18, 2020 · 1 comment
Open

Some questions about the code. #751

domef opened this issue Jun 18, 2020 · 1 comment

Comments

@domef
Copy link

domef commented Jun 18, 2020

I got some questions about the code:

  • you compute the mean after the computation of the loss, but in the loss functions you implemented the loss is always a scalar, what's the purpose?:

    loss = loss.mean()

  • in your code you never convert the numpy arrays created in the datasets into pytorch tensors. Does the dataloader (or something else) do an automatic conversion?

  • I think that max_objs used in the datasets should be equal to K used to extract peaks in the heatmaps. For example, in coco dataset max_objs is set to 128 (this means that if there are more than 128 annotations for a certain image, they are discarded) while K is set by default to 100. Therefore if I have an image with >100 annotations, some of them will be discarded. Is my example correct?

@ash2703
Copy link

ash2703 commented Nov 5, 2020

Yes, you can also set max_objs to the number of object present in the frame and mask the rest of the positions #820

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants