Skip to content

Commit c50bf4f

Browse files
authored
Change llvm-symbolizer to use --inlining (google#643)
The single dash -inlining is exotic. Change it to the double-dash --inlining. I removed most one-dash long options from llvm-symbolizer in <https://reviews.llvm.org/D106377> (I forgot that pprof is still using -inlining when I made the change.) -demangle=false is also exotic but not changed. It is currently implemented as a legacy alias (llvm/llvm-project@c558c22). We can change it to --no-demangle once support for llvm-symbolizer < 9.0 is dropped (https://reviews.llvm.org/D56773).
1 parent 4bb14d4 commit c50bf4f

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

internal/binutils/addr2liner_llvm.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ func newLLVMSymbolizer(cmd, file string, base uint64, isData bool) (*llvmSymboli
7676
}
7777

7878
j := &llvmSymbolizerJob{
79-
cmd: exec.Command(cmd, "-inlining", "-demangle=false"),
79+
cmd: exec.Command(cmd, "--inlining", "-demangle=false"),
8080
symType: "CODE",
8181
}
8282
if isData {

0 commit comments

Comments
 (0)