Opening the settings of a Socks5 Proxy with saved credentials deletes those credentials

[Redjard]

ZeroOmega version

3.3.16

Browser version & OS version

Firefox 133.0, Gentoo 6.6.47
Fennec 132.0.1, Android 13
Brave 1.57.57 Chromium: 116.0.5845.163, (Official Build) unknown (64-bit)

Issue occurs regardless of Socks5 (only ff) or Socks4 (none of them) with credentials being supported.

Problem description

When configuring a Socks Proxy with login, after saving and navigating away every load of that profile in options will delete the credentials.
This can be seen immediately when no other changes have been made, as right upon load the "Apply changes" button will light up. Navigating away does not undo this, the changes have to be discarded.
If instead "Apply changes" is clicked, the socks profile will be resaved without logins and fail on any later page loads.
It is an error that can happen easily and will later when discovered appear as an internet connection issue at first. I have experienced this many times over the years in using SwitchyOmega and confirmed the same to happen in ZeroOmega now.

Steps to Reproduce:

1. Create a Socks5 Profile (Socks4 seems to have the same issue but I never used socks4 proxies)
2. Enter credentials
3. Save
4. click on another tab and come back, or reload the settings page
5. The "Apply changes" button will light up and the credentials will be gone. Clicking the Authentication button will show the inputs empty.

Expected behavior:
Same as for http(s) credentials, the username and password should remain as-is in the auth popup, and should not be affected by navigating through the settings in any way.

Other observations:
Selecting http or https, entering credentials, then switching between http and https will preserve the credentials. Selecting socks or direct will remove them, even after selecting http(s) again. Entering credentials while having socks4/5 selected and switching to socks or direct will clear credentials, but switching to http(s) will preserve them.

[zero-top]

3.3.20 fixed.

https://addons.mozilla.org/en-US/firefox/addon/zeroomega/