There is a WPT here for the horizontal writing modes fwiw: https://github.com/web-platform-tests/wpt/blob/master/css/css-counter-styles/counter-style-at-rule/disclosure-styles.html

This is also relevant fwiw: https://github.com/w3c/csswg-drafts/issues/10321

implicit was renamed to auto: https://github.com/w3c/csswg-drafts/issues/10312

There's this section I originally wrote for theming high contrast mode: https://firefox-source-docs.mozilla.org/code-quality/coding-style/css_guidelines.html#high-contrast-mode

Heads up that I'm fixing this in https://github.com/web-platform-tests/wpt/pull/42112

Looks good to me!

This revision requires a Testing Policy Project Tag to be set before landing. Please apply one of testing-approved, testing-exception-unchanged, testing-exception-ui, testing-exception-elsewhere, testing-exception-other. Tip: this Firefox add-on makes it easy!

Looks good, thanks for fixing!

This revision requires a Testing Policy Project Tag to be set before landing. Please apply one of testing-approved, testing-exception-unchanged, testing-exception-ui, testing-exception-elsewhere, testing-exception-other. Tip: this Firefox add-on makes it easy!

@yoasif This is what @dao meant I think.

https://bugzilla.mozilla.org/show_bug.cgi?id=1519036 would be a better path forward if you have time to finish that :)

Thanks

You should use transform: translateY([y]px) or translate: 0 [y]px for this kind of tweak, rather than tweaking the margin (which is brittle in case the default margin gets changed).

This should probably be in browser/themes/osx/browser.css (as macOS specific theme CSS) or browser/base/content/browser.css (as content CSS that's essential for the browser to work), but browser/themes/shared/browser.inc.css seems wrong to me.

I have some doubts around how optimized those filmstrip SVGs are, but it doesn't sound like there's great automated tools to optimize anyway.

Just to reflect what @harry said and so it doesn't get lost from @dao's radar.

You can change https://searchfox.org/mozilla-central/rev/a5bf5d0720f9454687f500513ac82b0c8abce5a4/toolkit/themes/windows/global/button.css#47 to use :where() instead of :is(), which would solve this issue without an extra override.

I think @harry already did this with https://bugzilla.mozilla.org/show_bug.cgi?id=1704828, not sure this is still needed.

@dao's review would be really valuable here :)

You might want to run this through try to see if allowed-dupes.mn is happy. Btw, I think @jaws has a patch that updates some of these icons (see D111009)

Some issues:

• Still needs rebasing on top of m-c
• tab-audio-blocked.svg & tab-audio-playing.svg & tab-audio-muted.svg are unused by proton afaik, not sure there's much point in updating them
• badge-audio-playing.svg & tab-audio-playing-small.svg seem to be the same, could they just be combined in one if that's the case? avoids triggering allowed-dupes.mn too
• As a followup, worth asking UX for new icons here (I see there's no changed planned in the spreadsheet for those):

The fill-opacity: 1 declarations are not needed afaik, this should be the default value.