Issues related to deleting and undeleting/restoring pages and revisions (via action=delete and Special:Undelete). (Documentation)
This project is part of the core MediaWiki software itself.
Parent project: MediaWiki-General
Issues related to deleting and undeleting/restoring pages and revisions (via action=delete and Special:Undelete). (Documentation)
This project is part of the core MediaWiki software itself.
Parent project: MediaWiki-General
Yes, happens quite often during uploading.
Just to help me understand this issue - is it accurate that if a page is deleted directly, it is automatically removed from its Wikidata item, but if deleted with Nuke, this doesn't happen?
Change #1081215 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):
[mediawiki/extensions/AbuseFilter@master] Migrate 'ArticleDelete' hook to 'PageDelete' to fix error display
https://gerrit.wikimedia.org/r/1081215
Change #1081214 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):
[mediawiki/core@master] DeleteAction: Modernize displaying errors
https://gerrit.wikimedia.org/r/1081214
Looking at the UI error carefully, there are two problems:
Change #1076828 merged by jenkins-bot:
[mediawiki/core@master] specials: Catch RevisionAccessException and ignore on Special:Undelete
https://gerrit.wikimedia.org/r/1076828
Change #1076828 had a related patch set uploaded (by Umherirrender; author: Umherirrender):
[mediawiki/core@master] specials: Catch RevisionAccessException and ignore on Special:Undelete
https://gerrit.wikimedia.org/r/1076828
You know when you go to reproduce something and you can't.
This bug seems pretty straightforward. @Izno Would you mind grabbing a screenshot of the different sizes you mention in the task description so that we can repro the bug?
Error deleting file: Could not acquire lock. Somebody else is doing something to this file.
I compared the byte counts reported in Special:DeletedContributions with what I could calculate from action=query&prop=deletedrevisions.
Change #1063307 merged by jenkins-bot:
[mediawiki/core@master] Preload parent revision sizes for archive rows
https://gerrit.wikimedia.org/r/1063307
For QA I would recommend loading Special:DeletedContributions for a specific user, and ensure that the diff size for the revisions shown are the same as they are on Special:Undelete (you can get to the undelete special page by clicking the view link).
In T372459#10065048, @Mbch331 wrote:
Thank you @TheresNoTime and @Dreamy_Jazz for the backport and deploy. I'm seeing deleted contributions as expected now.
Mentioned in SAL (#wikimedia-operations) [2024-08-20T12:19:47Z] <dreamyjazz@deploy1003> Finished scap sync-world: Backport for [[gerrit:1063926|Fix DeletedContributions for user names containing spaces (T372444)]], [[gerrit:1064004|Allow ContributionsSpecialPage to accept usemodwiki IP addresses (T370413)]], [[gerrit:1064002|Allow ContributionsSpecialPage to accept usemodwiki IP addresses (T370413)]] (duration: 11m 38s)
Mentioned in SAL (#wikimedia-operations) [2024-08-20T12:12:09Z] <dreamyjazz@deploy1003> dreamyjazz, samtar: Backport for [[gerrit:1063926|Fix DeletedContributions for user names containing spaces (T372444)]], [[gerrit:1064004|Allow ContributionsSpecialPage to accept usemodwiki IP addresses (T370413)]], [[gerrit:1064002|Allow ContributionsSpecialPage to accept usemodwiki IP addresses (T370413)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)
Mentioned in SAL (#wikimedia-operations) [2024-08-20T12:08:08Z] <dreamyjazz@deploy1003> Started scap sync-world: Backport for [[gerrit:1063926|Fix DeletedContributions for user names containing spaces (T372444)]], [[gerrit:1064004|Allow ContributionsSpecialPage to accept usemodwiki IP addresses (T370413)]], [[gerrit:1064002|Allow ContributionsSpecialPage to accept usemodwiki IP addresses (T370413)]]
Change #1063926 merged by jenkins-bot:
[mediawiki/core@wmf/1.43.0-wmf.18] Fix DeletedContributions for user names containing spaces
https://gerrit.wikimedia.org/r/1063926
In T372444#10075918, @AntiCompositeNumber wrote:Can we get this backported ASAP? Special:DeletedContributions is a critical administrative tool.
Change #1063926 had a related patch set uploaded (by Samtar; author: Máté Szabó):
[mediawiki/core@wmf/1.43.0-wmf.18] Fix DeletedContributions for user names containing spaces
https://gerrit.wikimedia.org/r/1063926
Can we get this backported ASAP? Special:DeletedContributions is a critical administrative tool.
Change #1063307 had a related patch set uploaded (by Matěj Suchánek; author: Matěj Suchánek):
[mediawiki/core@master] Preload parent revision sizes for archive rows
https://gerrit.wikimedia.org/r/1063307