Reintroduce @protobuf-ts/runtime-rpc as a runtime dependency
#2113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a runtime dependency issue by reintroducing @protobuf-ts/runtime-rpc as a production dependency after it was accidentally removed when @protobuf-ts/plugin was moved to devDependencies.
- Adds
@protobuf-ts/runtime-rpcas a runtime dependency in the cache package - Restores only the necessary runtime dependency without bringing back the full plugin package and its 6 additional dependencies
Files not reviewed (1)
- packages/cache/package-lock.json: Language not supported
conorsloan
approved these changes
Aug 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2112
Related to: #2106
By moving
@protobuf-ts/pluginfrom dependencies to devDependencies,@protobuf-ts/runtime-rpcwhich is a runtime dependency was lost.This change reintroduced
@protobuf-ts/runtime-rpconly and not the entire@protobuf-ts/pluginpackage which has 6 other dependencies not needed during runtime.