Skip to content

Move snapshot repositories in a profile #451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
slawekjaranowski merged 1 commit into from
Mar 15, 2025
Merged

Move snapshot repositories in a profile #451

slawekjaranowski merged 1 commit into from
Mar 15, 2025

Conversation

@slawekjaranowski
Copy link
Member

@slawekjaranowski slawekjaranowski commented Mar 6, 2025 •
edited
Loading

@slawekjaranowski slawekjaranowski added enhancement New feature or request breaking Pull requests that break existing features labels Mar 6, 2025
@kwin
Copy link
Member

kwin commented Mar 6, 2025 •
edited
Loading

Why? Have you faced any issue in Maven projects?

I am a littlebit reluctant to introduce potentially breaking changes to Maven Parent without a real need....

@slawekjaranowski
Copy link
Member Author

slawekjaranowski commented Mar 7, 2025

Why? Have you faced any issue in Maven projects?

I am a littlebit reluctant to introduce potentially breaking changes to Maven Parent without a real need....

Discussion was in apache/maven-apache-parent#183
I think we can introduce it here as well.

@kwin
Copy link
Member

kwin commented Mar 7, 2025

Difference is: There was a concrete issue in ASF parent, but there is none I am aware of in Maven Parent.

@slawekjaranowski
Copy link
Member Author

slawekjaranowski commented Mar 7, 2025

Difference is: There was a concrete issue in ASF parent, but there is none I am aware of in Maven Parent.

The same problems can be in Mavens projects as was in ASF projects ... so I would like to be consistent with our resolutions.

Also I don't see that snapshot repositories are needed by default, so it can be a little break.

@slawekjaranowski slawekjaranowski added this to the 44 milestone Mar 12, 2025
@slawekjaranowski slawekjaranowski merged commit 925ccc9 into apache:master Mar 15, 2025
3 checks passed
@slawekjaranowski slawekjaranowski deleted the snap-profile branch March 15, 2025 18:57
@slachiewicz slachiewicz mentioned this pull request Aug 10, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Bukama Bukama Bukama approved these changes

@slachiewicz slachiewicz slachiewicz approved these changes

@kwin kwin Awaiting requested review from kwin

Assignees

@slawekjaranowski slawekjaranowski

Labels

breaking Pull requests that break existing features enhancement New feature or request

Projects

None yet

Milestone

44

Development

Successfully merging this pull request may close these issues.

4 participants

@slawekjaranowski @kwin @Bukama @slachiewicz