feat: Automatically trigger initialisation if cookiePolicy script is ran after DOM content has loaded#182
Merged
petesfrench merged 2 commits intomainfrom Dec 11, 2024
Merged
feat: Automatically trigger initialisation if cookiePolicy script is ran after DOM content has loaded#182petesfrench merged 2 commits intomainfrom
petesfrench merged 2 commits intomainfrom
Conversation
…ran after DOM content has loaded
Collaborator
|
LGTM! Tested both cases and everything worked correctly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Done
initfunction if thecookiePolicyscript is called after DOM content has loaded. I also as added a check with in theinitfunction to see if it has already ran to avoid it being ran twice.QA
npm run buildnpm run serverdeferattribute to the script tag)