feat(C++): Support underlying_type for union#7954
Merged
dbaileychess merged 4 commits intogoogle:masterfrom May 15, 2023
Merged
feat(C++): Support underlying_type for union#7954dbaileychess merged 4 commits intogoogle:masterfrom
dbaileychess merged 4 commits intogoogle:masterfrom
Conversation
f9c02b9 to
197a4c8
Compare
dbaileychess
requested changes
May 12, 2023
Collaborator
dbaileychess
left a comment
There was a problem hiding this comment.
The last thing I think is evolution test. It should be invalid to change the backing type of a union. Can you add this as well?
Contributor
Author
|
@dbaileychess Hi, I've added evolution tests for enum / union underlying type changes |
dbaileychess
approved these changes
May 15, 2023
Collaborator
|
Great! Thanks for the multiple edits. |
Contributor
|
Hi @sssooonnnggg , would you please briefly comment what is this change about? I see no description at all in the PR. Thanks |
Contributor
Author
|
Hi @jmillan , the default union implementation use a single byte to store union associative enums, which limits union count must smaller than 256 , this feature allow union to specify an underlying type to store union associative enums with arbitrary integer type. For example： |
jochenparm
pushed a commit
to jochenparm/flatbuffers
that referenced
this pull request
Oct 29, 2024
* feat(C++): support underlying type for union * chore: add conform checks for underlying type changes
jochenparm
pushed a commit
to jochenparm/flatbuffers
that referenced
this pull request
Oct 29, 2024
* feat(C++): support underlying type for union * chore: add conform checks for underlying type changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.