Merged
Conversation
Collaborator
|
Hey, please rebase this on the latest master branch so that this can be tested against Rust 1.70. Thank you for your PR! |
This is unnecessary, `std::env::home_dir()` was fixed in Rust 1.85.
Contributor
Author
|
Done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is unnecessary,
std::env::home_dir()was fixed in Rust 1.85.Our MSRV is still 1.70, but I'd argue this is fine, as it really is a bug in Rust. That's similar to if e.g.
std::sync::OnceLockwas broken in Rust 1.80; you wouldn't argue that this crate should include a fixed version ofOnceLock, you'd update your Rust version.See #104 and rust-lang/libs-team#372 (comment) for background.