Artifact comparison should use semantic version comparison. #1281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slawekjaranowski
approved these changes
Sep 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now this is a "business" kind of bug and I am surprised that this hasn't come up before. Dependencies, Plugins, etc, all use regular lexicographic comparison to order versions (where this is done by the plugin and not Resolver) whereas it should use semantic versioning (for example
GenericVersionfrom Resolver).I guess this hasn't been noticed because most people don't have any strange versioning schemes, but I have added some unit tests which break with regular string comparison (e.g.
1.0should be equivalent to1.0.0, etc.).