Use input() in nltk.chat.chatbot() for Jupyter support#3022
Merged
stevenbird merged 1 commit intonltk:developfrom Jul 19, 2022
Merged
Use input() in nltk.chat.chatbot() for Jupyter support#3022stevenbird merged 1 commit intonltk:developfrom
input() in nltk.chat.chatbot() for Jupyter support#3022stevenbird merged 1 commit intonltk:developfrom
Conversation
input() in nltk.chat.chatbot() for Jupyter support
Member
|
Thanks @tomaarsen |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3021
Hello!
Pull request overview
sys.stdin.readline()withinput()innltk.chat.chatbot()Details
The following snippet is used to let users pick which of the 5 NLTK chatbots should be instantiated:
nltk/nltk/chat/__init__.py
Lines 43 to 44 in 1f28903
However, the
sys.stdin.readline()constantly triggers in such a way thatchoiceis an empty string. This causes an endless loop, exactly as described in #3021:Note that this is the output directly after running the cell. Be warned when testing this, this ended up crashing my computer due to the endless loop.
Changes
This PR simply updates this somewhat outdated form of getting user input by using the better supported
input(). Running the cell now results in:After which the chatbot works like intended & expected.
Thank you @jmcelroy01 for raising this issue.