Skip to content

Expand OkHttp default retry exception predicate with SocketException#7057

Merged
jack-berg merged 1 commit intoopen-telemetry:mainfrom
YuriyHolinko:extend-default-predicate
Jan 30, 2025
Merged

Expand OkHttp default retry exception predicate with SocketException#7057
jack-berg merged 1 commit intoopen-telemetry:mainfrom
YuriyHolinko:extend-default-predicate

Conversation

@YuriyHolinko
Copy link
Contributor

@YuriyHolinko YuriyHolinko commented Jan 30, 2025

Extended the default predicate as mentioned here #6991 (comment)

@YuriyHolinko YuriyHolinko requested a review from a team as a code owner January 30, 2025 13:54
@codecov
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.95%. Comparing base (8e31bf4) to head (18e326f).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #7057   +/-   ##
=========================================
  Coverage     89.95%   89.95%           
- Complexity     6668     6669    +1     
=========================================
  Files           748      748           
  Lines         20105    20107    +2     
  Branches       1970     1971    +1     
=========================================
+ Hits          18085    18087    +2     
  Misses         1427     1427           
  Partials        593      593           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jack-berg
Copy link
Member

Thanks for following up! I missed SocketException

@jack-berg jack-berg merged commit 19e964a into open-telemetry:main Jan 30, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants