📝 Update template docs with more info about url_for
#5937
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The id argument refers to the the id parameter sent to the read_item() function call.
Contributor
|
📝 Docs preview for commit 0e2afee at: https://63d672b64f22084e50eecfa3--fastapi.netlify.app |
|
The extra example looks out of place in the normal pattern of the FastAPI documentation. I'd update the |
Member
|
📝 Docs preview for commit 83babfb at: https://2f348dd8.fastapitiangolo.pages.dev |
url_for
Member
|
Thanks @EzzEddin! 🍰 And thanks for the idea @mjpieters! ☕ I updated the docs, the example code, and the tests a bit. 🤓 |
nilslindemann
pushed a commit
to nilslindemann/fastapi
that referenced
this pull request
Jan 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds more clarity on how to pass arguments to a URL route. It would save developers time figuring that out on their own, especially since the syntax of the
url_foris a bit different from the Django's{% url %}