Menu

#214 Tracking Drop-Down does not work correctly

General
closed
5
2005-09-12
2005-08-26
CLPablo
No

Two Parts:

1) user-specific options

On the tracking page (/users/tracking-index.php), the
drop-down list allowing you to select a username to
show assigned tickets to was not working. No matter
which username I would select, it would show no
currently assigned tracking items.

I changed line 75 of the tracking-index.php file from:
"$opts["u:$id"] = sprintf(_("Show only tracking
assigned to %s"), $name);"

to:

$opts["u:$name"] = sprintf(_("Show only tracking
assigned to %s"), $name);

It now uses the $name (user's username) as a value in
the select option rather than the id number. This
yields correct results on the page.

2) all and nobody options

On the same drop-down list, there are currently two
blank lines that appear. They are supposed to be
options to select all tracking items or any item not
assigned to anyone.

An array of options is created on lines 70 - 72 of
tracking-index.php.

Those lines look like this after installing 1.5.5:
$opts = array('all' => __("Show All Tracking"),
'unassigned' => __("Show only tracking not assigned
to anyone")
);

I modified them so they look like this:
$opts = array('all' => "Show All Tracking",
'unassigned' => "Show only tracking not assigned to
anyone"
);

Now those top 2 options work fine.

If someone gets a few spare moments, could they e-mail
me what the purpose of the __() function is? I'm just
a PHP dabbler and can't figure it out.

Discussion

  • Martin Stevens

    Martin Stevens - 2005-08-27

    Logged In: YES
    user_id=255024

    the __() function allows any text in the brackets to be a
    translateale (?) string.

    Can you supply a patch for the changes that you have made,
    or even better publish it as a baz archive, if you are not
    using baz, send the patch anyway and i'll try and integrate
    it and publish an archive for matt to pull from

    HTH

    Regards

    Martin Stevens

     
  • Martin Stevens

    Martin Stevens - 2005-09-11

    Logged In: YES
    user_id=255024

    This is now fixed in the man irm-pqm repository

     
  • Martin Stevens

    Martin Stevens - 2005-09-12
    • status: open --> closed
     
  • Martin Stevens

    Martin Stevens - 2005-09-12
    • labels: 713378 --> fixed-in-dev
    • assigned_to: nobody --> budgester
     

Log in to post a comment.