Menu

#231 1.5.7 Hardcoded strings

General
closed
5
2005-10-27
2005-10-20
franjb68
No

I've found the following hardcoded strings in the
latest snapshot:

include/device.class.php
Lines:
56 "Add Device"
164 "Delete Field"
380 "Add"
381 "Reset"
398 "Update"
403 "Delete"

Discussion

  • Martin Stevens

    Martin Stevens - 2005-10-20
    • assigned_to: nobody --> budgester
    • labels: 105750 --> 713378
     
  • Martin Stevens

    Martin Stevens - 2005-10-20

    Logged In: YES
    user_id=255024

    Whoops, got carried away getting devices working and forgot
    about strings, will fix asap, should be in tommorows snapshot

     
  • Martin Stevens

    Martin Stevens - 2005-10-22
    • status: open --> closed
     
  • Martin Stevens

    Martin Stevens - 2005-10-22

    Logged In: YES
    user_id=255024

    You know the drill fran

     
  • Martin Stevens

    Martin Stevens - 2005-10-22

    Logged In: YES
    user_id=255024

    This bug has now been fixed in the irm-pqm archive.

    Thanks for reporting it.

     
  • franjb68

    franjb68 - 2005-10-24
    • labels: 713378 --> 105750
    • status: closed --> open
     
  • franjb68

    franjb68 - 2005-10-24

    Logged In: YES
    user_id=1134235

    >You know the drill fran

    I dont know what does that mean. My English is not so good :-)

    More hardcoded strings:

    users/knowledgebase-article-preview.php
    Line 78 "Re-edit article"
    Line 112 "Add article"
    (Suggestion on this file: adding a PRINT "<br/><hr><br/>";
    line just before the "Add article" button (line 112) makes
    the form look better)

    users/knowledgebase-article-modify.php
    Line 63 "Preview Article"
    Line 64 "Reset"

    users/reports/tracking.php
    Line 182 value=Go

     
  • franjb68

    franjb68 - 2005-10-24

    Logged In: YES
    user_id=1134235

    Another one:

    include/functions.php
    line 139 <a href=\"$userbase/index.php\">Home</a>

     
  • Martin Stevens

    Martin Stevens - 2005-10-24

    Logged In: YES
    user_id=255024

    This bug has now been fixed in the irm-pqm archive.

    Thanks for reporting it.

     
  • Martin Stevens

    Martin Stevens - 2005-10-24
    • labels: 105750 --> 771658
    • status: open --> closed
     
  • franjb68

    franjb68 - 2005-10-25
    • labels: 771658 --> 105750
    • status: closed --> open
     
  • franjb68

    franjb68 - 2005-10-25

    Logged In: YES
    user_id=1134235

    A couple more:

    users/helper-preview.php
    Line 136: value=\"Add job\"

    users/reports/default.php
    Line 93: value=Go

     
  • franjb68

    franjb68 - 2005-10-25

    Logged In: YES
    user_id=1134235

    And these ones:

    include/ports.functions.php
    Lines:
    334 "Connected to port %s on computer %s"
    341 "Connected to port %s on network device %s"
    348 "Connected to port %s on $pType device %s"

    The last one should have a %s instead of $pType.

     
  • Martin Stevens

    Martin Stevens - 2005-10-25

    Logged In: YES
    user_id=255024

    This bug has now been fixed in the irm-pqm archive.

    Thanks for reporting it.

     
  • Martin Stevens

    Martin Stevens - 2005-10-25

    Logged In: YES
    user_id=255024

    Any more ? :-)

     
  • Martin Stevens

    Martin Stevens - 2005-10-25
    • labels: 105750 --> 771658
    • status: open --> closed
     
  • franjb68

    franjb68 - 2005-10-27

    Logged In: YES
    user_id=1134235

    Nope, but a couple I reported before aren't corrected. :-)

    users/helper-preview.php
    Line 136: value=\"Add job\"

    users/reports/default.php
    Line 93: value=Go

     
  • franjb68

    franjb68 - 2005-10-27
    • labels: 771658 --> 105750
    • status: closed --> open
     
  • franjb68

    franjb68 - 2005-10-27

    Logged In: YES
    user_id=1134235

    Another couple (don't forget the ones I told you on 12:52):

    include/computers.functions.php
    Line 252: <input type=submit value=Add>
    Line 253: <input type=Reset value=Reset>

     
  • Martin Stevens

    Martin Stevens - 2005-10-27

    Logged In: YES
    user_id=255024

    Any more ?

    I know it's a pain, but any chance of reporting strings on a
    seperate bug ? I'm beginning to lose track on the bug.

    Regards

    Martin

     
  • Martin Stevens

    Martin Stevens - 2005-10-27

    Logged In: YES
    user_id=255024

    This bug has now been fixed in the irm-pqm archive.

    Thanks for reporting it.

     
  • Martin Stevens

    Martin Stevens - 2005-10-27
    • labels: 105750 --> fixed-in-irm-pqm
    • status: open --> closed
     

Log in to post a comment.