Skip to content

fix(material/select): error if selected value is accessed too early #23378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wagnermaciel merged 1 commit into from
Sep 20, 2021
Merged

fix(material/select): error if selected value is accessed too early #23378

wagnermaciel merged 1 commit into from
Sep 20, 2021

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Aug 16, 2021

Fixes that the select throws if the selected value is accessed before everything is initialized.

Fixes #23371.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent G This is is related to a Google internal issue target: patch This PR is targeted for the next patch release labels Aug 16, 2021
@crisbeto crisbeto requested a review from jelbourn August 16, 2021 04:19
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 16, 2021
crisbeto added a commit to crisbeto/material2 that referenced this pull request Aug 20, 2021
@crisbeto
fix(material/chips): error if selected value is accessed too early
fde293e 
Similar issue to angular#23378. The chip list will throw an error if the `selected` value is accessed before the selection model has been initialized.
@crisbeto crisbeto mentioned this pull request Aug 20, 2021
Merged
crisbeto added a commit to crisbeto/material2 that referenced this pull request Aug 24, 2021
@crisbeto
fix(material/chips): error if selected value is accessed too early
d8467af 
Similar issue to angular#23378. The chip list will throw an error if the `selected` value is accessed before the selection model has been initialized.
@crisbeto
fix(material/select): error if selected value is accessed too early
42152eb 
Fixes that the select throws if the `selected` value is accessed before everything is initialized.

Fixes angular#23371.
@crisbeto crisbeto force-pushed the 23371/select-early-access branch from ba03388 to 42152eb Compare August 24, 2021 05:11
jelbourn
jelbourn approved these changes Aug 28, 2021
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label Aug 28, 2021
zarend pushed a commit that referenced this pull request Sep 7, 2021
@crisbeto
fix(material/chips): error if selected value is accessed too early (#…
875f00d 
…23419)

Similar issue to #23378. The chip list will throw an error if the `selected` value is accessed before the selection model has been initialized.
zarend pushed a commit that referenced this pull request Sep 7, 2021
@crisbeto @zarend
fix(material/chips): error if selected value is accessed too early (#…
eeac3e6 
…23419)

Similar issue to #23378. The chip list will throw an error if the `selected` value is accessed before the selection model has been initialized.

(cherry picked from commit 875f00d)
@wagnermaciel wagnermaciel merged commit a41ac2b into angular:master Sep 20, 2021
wagnermaciel pushed a commit that referenced this pull request Sep 20, 2021
@crisbeto @wagnermaciel
fix(material/select): error if selected value is accessed too early (#…
aad5569 
…23378)

Fixes that the select throws if the `selected` value is accessed before everything is initialized.

Fixes #23371.

(cherry picked from commit a41ac2b)
@sync-by-unito sync-by-unito bot mentioned this pull request Oct 1, 2021
Closed
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Oct 21, 2021

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement G This is is related to a Google internal issue P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug(mat-select): accessing selected field on a MatSelect instance causes exception

3 participants

@crisbeto @jelbourn @wagnermaciel