Skip to content

fix(material-experimental/mdc-menu): Use body1 typography for menu content #23657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mmalerba merged 1 commit into from
Sep 30, 2021
Merged

fix(material-experimental/mdc-menu): Use body1 typography for menu content #23657

mmalerba merged 1 commit into from
Sep 30, 2021
+1 −0

Conversation

@mmalerba
Copy link
Contributor

@mmalerba mmalerba commented Sep 28, 2021

We already fixed this for menu items, but MDC also sets the wrong
typography level on the menu content element, which can bleed through
into people's custom menu content.

@mmalerba
fix(material-experimental/mdc-menu): Use body1 typography for menu co…
bcc25f3 
…ntent

We already fixed this for menu items, but MDC also sets the wrong
typograph level on the menu content element, which can bleed through
into people's custom menu content.
@mmalerba mmalerba requested a review from crisbeto September 28, 2021 23:57
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 28, 2021
crisbeto
crisbeto approved these changes Sep 29, 2021
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added target: patch This PR is targeted for the next patch release action: merge The PR is ready for merge by the caretaker P2 The issue is important to a large percentage of users, with a workaround labels Sep 29, 2021
@mmalerba mmalerba merged commit 3181780 into angular:master Sep 30, 2021
mmalerba added a commit that referenced this pull request Sep 30, 2021
@mmalerba
fix(material-experimental/mdc-menu): Use body1 typography for menu co…
b72c177 
…ntent (#23657)

We already fixed this for menu items, but MDC also sets the wrong
typograph level on the menu content element, which can bleed through
into people's custom menu content.

(cherry picked from commit 3181780)
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Oct 31, 2021

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@crisbeto crisbeto crisbeto approved these changes

Assignees

@crisbeto crisbeto

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mmalerba @crisbeto