Skip to content

fix(material-experimental/mdc-card): action alignment not working #23742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
andrewseguin merged 1 commit into from
Oct 19, 2021
Merged

fix(material-experimental/mdc-card): action alignment not working #23742

andrewseguin merged 1 commit into from
Oct 19, 2021

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Oct 13, 2021

We were adding the mat-mdc-card-actions-align-end class, but we weren't using it which meant that <mat-card-actions align="end"> didn't work.

@crisbeto
fix(material-experimental/mdc-card): action alignment not working
5455676 
We were adding the `mat-mdc-card-actions-align-end` class, but we weren't using it which meant that `<mat-card-actions align="end">` didn't work.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent G This is is related to a Google internal issue target: patch This PR is targeted for the next patch release labels Oct 13, 2021
@crisbeto crisbeto requested a review from jelbourn October 13, 2021 07:18
@crisbeto crisbeto requested a review from mmalerba as a code owner October 13, 2021 07:18
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 13, 2021
jelbourn
jelbourn approved these changes Oct 14, 2021
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label Oct 14, 2021
@andrewseguin andrewseguin merged commit bfea409 into angular:master Oct 19, 2021
andrewseguin pushed a commit that referenced this pull request Oct 19, 2021
@crisbeto @andrewseguin
fix(material-experimental/mdc-card): action alignment not working (#2…
d8b5d9f 
…3742)

We were adding the `mat-mdc-card-actions-align-end` class, but we weren't using it which meant that `<mat-card-actions align="end">` didn't work.

(cherry picked from commit bfea409)
andrewseguin pushed a commit that referenced this pull request Oct 19, 2021
@crisbeto @andrewseguin
fix(material-experimental/mdc-card): action alignment not working (#2…
2e747ac 
…3742)

We were adding the `mat-mdc-card-actions-align-end` class, but we weren't using it which meant that `<mat-card-actions align="end">` didn't work.

(cherry picked from commit bfea409)
forsti0506 pushed a commit to forsti0506/components that referenced this pull request Oct 22, 2021
@crisbeto
fix(material-experimental/mdc-card): action alignment not working (an…
63894bf 
…gular#23742)

We were adding the `mat-mdc-card-actions-align-end` class, but we weren't using it which meant that `<mat-card-actions align="end">` didn't work.
@sync-by-unito sync-by-unito bot mentioned this pull request Nov 1, 2021
Closed
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Nov 19, 2021

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jelbourn jelbourn jelbourn approved these changes

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement G This is is related to a Google internal issue P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@crisbeto @jelbourn @andrewseguin