fix: add @CanIgnoreReturnValue to avoid errorprone errors.#1716
Merged
suztomo merged 1 commit intogoogleapis:mainfrom Sep 1, 2022
Merged
fix: add @CanIgnoreReturnValue to avoid errorprone errors.#1716suztomo merged 1 commit intogoogleapis:mainfrom
@CanIgnoreReturnValue to avoid errorprone errors.#1716suztomo merged 1 commit intogoogleapis:mainfrom
Conversation
2d7152b to
6d42922
Compare
In the monorepo, this blocks the build from succeeding. Fixes googleapis#1710.
6d42922 to
51107d1
Compare
@CanIgnoreReturnValue to avoid errorprone errors.@CanIgnoreReturnValue to avoid errorprone errors.
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
Member
|
"ci / lint" has been failing and it's not required check. Don't worry about it. #1691 (comment) |
Contributor
Author
Sent separate pr #1717 to do lint cleanup. |
suztomo
approved these changes
Sep 1, 2022
Member
|
@blakeli0 (This week's release manager) Can you release this fix? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the monorepo, this blocks the build from succeeding.
Fixes #1710.