feat: support PostgreSQL END statement#2131

Merged

olavloite merged 2 commits intomainfrom

support-pg-end-statement

Nov 4, 2022

Collaborator

olavloite commented Oct 28, 2022

Adds support for the PostgreSQL END statement in the Connection API.

See also https://www.postgresql.org/docs/current/sql-end.html

Fixes #2130


          feat: support PostgreSQL END statement

b4374dd

Adds support for the PostgreSQL END statement in the Connection API.

Fixes #2130

olavloite requested a review from a team

October 28, 2022 19:33

olavloite requested a review from a team as a code owner

October 28, 2022 19:33

product-auto-label bot added size: xl api: spanner labels


          🦉 Updates from OwlBot post-processor

df3bcb9

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

olavloite requested a review from rajatbhatta

November 3, 2022 06:53

Contributor

rajatbhatta commented Nov 4, 2022

@olavloite: Generally looks good to me except that I have one question. How are we updating the .sql files under main/resources, and test/resources? Do we use any automated way to generate/change these?

Collaborator Author

olavloite commented Nov 4, 2022

@olavloite: Generally looks good to me except that I have one question. How are we updating the .sql files under main/resources, and test/resources? Do we use any automated way to generate/change these?

Yes, those files are automatically generated from the ClientSideStatements.json file (specifically from the exampleStatements elements in that JSON file). So whenever we add a new (simple) statement to one of these files, we should:

Add a number examples for the statement to the JSON file.
Run the command listed here. That will generate both valid and invalid statements for the command and add these to the generated SQL test scripts.

rajatbhatta approved these changes

View reviewed changes

olavloite merged commit 4c29c17 into main

olavloite deleted the support-pg-end-statement branch

November 4, 2022 08:27

release-please bot mentioned this pull request

chore(main): release 6.33.0 #2137

Merged

gcf-merge-on-green bot pushed a commit that referenced this pull request


          chore(main): release 6.33.0 (#2137)

820934c

🤖 I have created a release *beep* *boop*
---


## [6.33.0](https://togithub.com/googleapis/java-spanner/compare/v6.32.0...v6.33.0) (2022-11-17)


### Features

* Adding samples for Jsonb data type ([#2147](https://togithub.com/googleapis/java-spanner/issues/2147)) ([1112203](https://togithub.com/googleapis/java-spanner/commit/1112203bd6bde68fcd04ae68a2a31ec88dd5b1ac))
* Analyze update returns param types ([#2156](https://togithub.com/googleapis/java-spanner/issues/2156)) ([7c5e3da](https://togithub.com/googleapis/java-spanner/commit/7c5e3da4c128cb9220213db8b3e2291e33566715))
* Support DML with Returning clause in Connection API ([#1978](https://togithub.com/googleapis/java-spanner/issues/1978)) ([aac20be](https://togithub.com/googleapis/java-spanner/commit/aac20bedf9ee7a6a2170f87fa88373b7d364ed9f))
* Support PostgreSQL END statement ([#2131](https://togithub.com/googleapis/java-spanner/issues/2131)) ([4c29c17](https://togithub.com/googleapis/java-spanner/commit/4c29c17fb35e51fdad99e393a8f6bb57c914dc8a))
* Update transaction.proto to include different lock modes ([#2112](https://togithub.com/googleapis/java-spanner/issues/2112)) ([d0195b4](https://togithub.com/googleapis/java-spanner/commit/d0195b45423b73969636bc911980613a46dffa97))


### Dependencies

* Update dependency com.google.cloud:google-cloud-monitoring to v3.7.0 ([#2164](https://togithub.com/googleapis/java-spanner/issues/2164)) ([82385b8](https://togithub.com/googleapis/java-spanner/commit/82385b8526e0299e8c85e4435e3c740474de854c))
* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.6 ([#2150](https://togithub.com/googleapis/java-spanner/issues/2150)) ([dba545f](https://togithub.com/googleapis/java-spanner/commit/dba545ff5ebb069a78b42cbffff032d66dc3d062))
* Update dependency com.google.cloud:google-cloud-trace to v2.6.0 ([#2165](https://togithub.com/googleapis/java-spanner/issues/2165)) ([99f2779](https://togithub.com/googleapis/java-spanner/commit/99f277974fdcebf587d1e25ad643575e15cee7ff))
* Update dependency org.graalvm.buildtools:junit-platform-native to v0.9.17 ([#2144](https://togithub.com/googleapis/java-spanner/issues/2144)) ([dd24b89](https://togithub.com/googleapis/java-spanner/commit/dd24b894fd80ccc962a414bb404d9624336f4612))
* Update dependency org.openjdk.jmh:jmh-core to v1.36 ([#2160](https://togithub.com/googleapis/java-spanner/issues/2160)) ([29f9096](https://togithub.com/googleapis/java-spanner/commit/29f9096d1a10bfb9eacdbc4d6dbc4bc9c7ed05c1))
* Update dependency org.openjdk.jmh:jmh-generator-annprocess to v1.36 ([#2161](https://togithub.com/googleapis/java-spanner/issues/2161)) ([9148aa3](https://togithub.com/googleapis/java-spanner/commit/9148aa37bfb61af25023d56bfcf6d0e735e51b9a))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: spanner size: xl