Skip to content

fix: Allow dropping cleaned-up keys #911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
acocuzzo merged 16 commits into from
May 5, 2023
Merged

fix: Allow dropping cleaned-up keys #911

acocuzzo merged 16 commits into from
May 5, 2023
+126 −12

Conversation

@acocuzzo
Copy link
Contributor

@acocuzzo acocuzzo commented May 5, 2023 •
edited
Loading

Fixes #913 🦕

@acocuzzo acocuzzo requested review from a team as code owners May 5, 2023 00:54
@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcf bot commented May 5, 2023 •
edited
Loading

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: pubsub Issues related to the googleapis/python-pubsub API. labels May 5, 2023
@acocuzzo acocuzzo marked this pull request as draft May 5, 2023 00:55
@acocuzzo acocuzzo changed the title fix assert fail for dropping duplicate keys fix: Allow dropping duplicate keys May 5, 2023
@acocuzzo acocuzzo added the owlbot:run Add this label to trigger the Owlbot post processor. label May 5, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 5, 2023
@acocuzzo acocuzzo changed the title fix: Allow dropping duplicate keys fix: Allow dropping cleaned-up keys May 5, 2023
@acocuzzo acocuzzo marked this pull request as ready for review May 5, 2023 18:53
@acocuzzo acocuzzo added the owlbot:run Add this label to trigger the Owlbot post processor. label May 5, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 5, 2023
@acocuzzo acocuzzo merged commit 4b3157c into googleapis:main May 5, 2023
@release-please release-please bot mentioned this pull request May 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kamalaboulhosn kamalaboulhosn kamalaboulhosn approved these changes

Assignees

@hongalex hongalex

Labels

api: pubsub Issues related to the googleapis/python-pubsub API. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix assertion error for messages_on_hold._activate_ordering_keys

3 participants

@acocuzzo @kamalaboulhosn @hongalex