Expose SecurityLevel on server-side#8943
Merged
sanjaypujare merged 1 commit intogrpc:masterfrom May 17, 2022
Merged
Conversation
|
|
sanjaypujare
reviewed
Mar 1, 2022
sanjaypujare
reviewed
Mar 1, 2022
sanjaypujare
reviewed
Mar 1, 2022
sanjaypujare
reviewed
Mar 1, 2022
sanjaypujare
reviewed
Mar 1, 2022
1b247d6 to
16428c1
Compare
16428c1 to
8ca5e58
Compare
Member
|
@sanjaypujare, what's the state of this? |
Contributor
|
I'll take care of this today - for sure. |
Member
|
@sanjaypujare, shouldn't this have had a second maintainer review? |
Contributor
|
Yes, you are right. What do we do now? Do you want to review? If you see issues we can revert and ask them to resubmit. Sorry about that. |
Member
|
I'll review, probably later today. |
ejona86
reviewed
May 17, 2022
Member
ejona86
left a comment
There was a problem hiding this comment.
LGTM.
I could have some nits, and getAttributes() should never be null. But this is fine.
Contributor
Thanks. So no more action needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a shot to #7719.
Added a new method to ServerCall which returns
SecurityLevel.NONEand ServerCallImpl returns the security levelgetAttributes().get(ATTR_SECURITY_LEVEL),in the case of uncertainty will return a lower level of security.