[TS] Signature method of Interceptor using Dispatcher#compose

[clovis-guillemot]

Bug Description

Cannot define a custom Interceptor for Dispatcher#compose using TS

Reproducible By

N/A

Expected Behavior

No change when migrate from interceptors to compose :
From

const client = new Client(url, {
        interceptors: {
            Client: [hawkInterceptor],
        },
})

To :

const client = new Client(url).compose(hawkInterceptor)

Logs & Screenshots

const client = new Client(url).compose(hawkInterceptor)

import * as Hawk from 'hawk'
import {type Dispatcher} from 'undici'

import {getConfig} from '#/utils'
import {getCurrentUniverseUrl} from '#/utils/urls'

export const hawkInterceptor = (dispatch: Dispatcher['dispatch']) => {
    return function HawhAuthorizationHeader(
        opts: Dispatcher.DispatchOptions,
        handler: Dispatcher.DispatchHandlers
    ) {
        const authConfig = getConfig('auth')
        const {header: authorization} = Hawk.client.header(
            `${getCurrentUniverseUrl()}${opts.path}`,
            opts.method,
            {
                credentials: {
                    algorithm: 'sha256',
                    ...authConfig.hawk,
                },
            }
        )
        if (!opts.headers) opts.headers = {}
        if (authorization) {
            opts.headers = {...opts.headers, authorization}
        }
        return dispatch(opts, handler)
    }
}

Environment

Node 20
Undici : ^6.10.0 (6.10.1)

Additional context

[metcoder95]

I see the problem, the types define that it expects a dispatch as argument, not a curried function that returns a dispatch.

Would you like to send a PR?

undici/types/dispatcher.d.ts

Line 23 in fcbf6de

compose(...dispatchers: Dispatcher['dispatch'][]): Dispatcher.ComposedDispatcher;

[clovis-guillemot]

I see the problem, the types define that it expects a dispatch as argument, not a curried function that returns a dispatch.

Would you like to send a PR?

undici/types/dispatcher.d.ts

Line 23 in fcbf6de

compose(...dispatchers: Dispatcher['dispatch'][]): Dispatcher.ComposedDispatcher;

Yes I can send a PR for that. Using DispatcherInterceptor type maybe ? Or will be also deprecated ?

[clovis-guillemot]

can you approve workflows on my PR @metcoder95 , please ?

[clovis-guillemot]

Codecov report seems OK ✅