feat(#2264): Expose Retry Handler

[metcoder95]

This relates to...

• Closes Retry #2264

Rationale

Changes

• Retry Agent
• Documentation
• Testing

Features

Bug Fixes

Breaking Changes and Deprecations

Status

• I have read and agreed to the Developer's Certificate of Origin
• Tested
• Benchmarked (optional)
• Documented
• Review ready
• In review
• Merge ready

[ronag]

Unfortunately I think retry is more complicated than this. See:

• https://github.com/nxtedition/nxt-lib/blob/e3ac11edbd265838cce537b0f4ab8ea298588f79/undici/interceptor/response-body-retry.js
• https://github.com/nxtedition/nxt-lib/blob/e3ac11edbd265838cce537b0f4ab8ea298588f79/undici/interceptor/response-retry.js
• https://github.com/nxtedition/nxt-lib/blob/e3ac11edbd265838cce537b0f4ab8ea298588f79/undici/interceptor/response-status-retry.js

[metcoder95]

Hey @ronag! Yes, I’m basing most of this work on your implementations, I just started the work and opened the draft so I do not miss it and not make a mess with my local branches nor stash when switching between them. I’ll ping you once more when I have something more solid 😉

[kibertoad]

mockttp provides a very convenient way for testing weirder edge cases, such as connection lost or connection cancelled, highly recommend it.

You can look up the code examples here: https://github.com/kibertoad/undici-retry/blob/main/test/undiciRetry.spec.ts

[kibertoad]

why no 429?

[metcoder95]

I haven't implemented that one yet; as its nature is coming from a rate-limit logic, we need to handle its Retry-After header; I'm planning to add settings specifically to it and its own default logic

[metcoder95]

More testing and docs/types is missed, but should be good already for review 👍

cc: @ronag

[codecov-commenter]

Codecov Report

❌ Patch coverage is 72.93233% with 36 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.05%. Comparing base (e39a632) to head (26d492b).
⚠️ Report is 1308 commits behind head on main.

Files with missing lines	Patch %	Lines
lib/handler/RetryHandler.js	70.00%	36 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2281      +/-   ##
==========================================
- Coverage   85.54%   85.05%   -0.50%     
==========================================
  Files          76       77       +1     
  Lines        6858     7046     +188     
==========================================
+ Hits         5867     5993     +126     
- Misses        991     1053      +62     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[metcoder95]

Applied on 1ed45f3 @ronag 👍

[ronag]

@metcoder95 are we ready here?

[metcoder95]

Yes 👍

[Ethan-Arrowood]

Nice!

[jiyuu-jin]

Is this exposed anywhere in the current NodeJS version?

[metcoder95]

This is exposed only through undici