Memory mode: Adding support for synchronous instruments - Last Value aggregation#6196
Merged
jack-berg merged 2 commits intoopen-telemetry:mainfrom Feb 8, 2024
Conversation
Contributor
Author
|
@jack-berg Last aggregator 🎉 |
This was referenced Feb 5, 2024
jack-berg
approved these changes
Feb 7, 2024
...BasedTest/java/io/opentelemetry/sdk/metrics/internal/state/tester/DoubleLastValueTester.java
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6196 +/- ##
============================================
- Coverage 91.06% 91.04% -0.02%
- Complexity 5672 5678 +6
============================================
Files 620 621 +1
Lines 16560 16603 +43
Branches 1690 1698 +8
============================================
+ Hits 15080 15116 +36
- Misses 993 996 +3
- Partials 487 491 +4 ☔ View full report in Codecov by Sentry. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Epic
This is one of many PRs that implement #5105. See the complete plan here.
Specifically, this PR adds the implementation of
MemoryModefor the synchronous instrument: counter.What was done here?
This PR adds support for Memory mode for Last Value Aggregation. It contains:
doAggregateThenMaybeResetfor bothLongLastValueAggregator.HandleandDoubleLastValueAggregator.Handle.LongLastValueAggregatorandDoubleLastValueAggregator