PR 6524 with amendments#6569
Conversation
…pagation/CaseInsensitiveMapTest.java
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6569 +/- ##
============================================
- Coverage 90.63% 90.61% -0.03%
- Complexity 6228 6260 +32
============================================
Files 679 689 +10
Lines 18661 18704 +43
Branches 1842 1844 +2
============================================
+ Hits 16914 16948 +34
- Misses 1189 1200 +11
+ Partials 558 556 -2 ☔ View full report in Codecov by Sentry. |
| m.forEach(this::put); | ||
| } | ||
|
|
||
| private static String getKeyLowerCase(@Nonnull String key) { |
There was a problem hiding this comment.
I think we normally don't include NonNull annotations?
There was a problem hiding this comment.
hmm. I don't remember either way. Happy to remove if you think we should skip it.
It's been a while since I last read it, thank you for editing my test case. It's also my first time contributing code |
Replacement for #6524 with amendments to the test and the implementation. @junwense I accidentally pushed unverified commits to your main branch. Please feel free to reset your main branch to remove them.