Added support for PHP 8.1 (currently in RC1) to the C extension#8964
Merged
haberman merged 1 commit intoprotocolbuffers:3.18.xfrom Sep 10, 2021
Merged
Added support for PHP 8.1 (currently in RC1) to the C extension#8964haberman merged 1 commit intoprotocolbuffers:3.18.xfrom
haberman merged 1 commit intoprotocolbuffers:3.18.xfrom
Conversation
TeBoring
approved these changes
Sep 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This switches to new interfaces for
spl_ce_ArrayAccessandspl_ce_Countable(zend_ce_arrayaccessandzend_ce_countable, respectively). It polyfillszend_ce_countablefor old versions of PHP.There is also a small fix for the tests to fix the following error:
In PHP float array keys are truncated to integer, and this has nothing to do with protobuf.
The pure PHP library may require further fixes to support 8.1. I was not able to resolve those issues at this time.
Fixes: #8711