This repository was archived by the owner on Sep 26, 2023. It is now read-only.
feat: update DirectPath xds scheme#1585
Merged
meltsufin merged 1 commit intogoogleapis:mainfrom Jan 5, 2022
Merged
Conversation
meltsufin
approved these changes
Jan 5, 2022
| @@ -339,7 +339,8 @@ && isOnComputeEngine()) { | |||
| isDirectPathXdsEnabled = Boolean.parseBoolean(envProvider.getenv(DIRECT_PATH_ENV_ENABLE_XDS)); | |||
| if (isDirectPathXdsEnabled) { | |||
| // google-c2p resolver target must not have a port number | |||
Member
There was a problem hiding this comment.
Should the comment be updated too?
Contributor
Author
There was a problem hiding this comment.
Thanks for asking. I think the comment should be fine as we will eventually use google-c2p once google-c2p-experimental is stable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow grpc/grpc-java#8744 to update the xds scheme for DirectPath.