Skip to content

fix: SAFEPATHCHARS_URLENCODER includes +#955

Merged
chingor13 merged 1 commit intomasterfrom
elharo-patch-2
Jan 22, 2020
Merged

fix: SAFEPATHCHARS_URLENCODER includes +#955
chingor13 merged 1 commit intomasterfrom
elharo-patch-2

Conversation

@elharo
Copy link
Contributor

@elharo elharo commented Jan 22, 2020

@elharo elharo requested a review from a team as a code owner January 22, 2020 19:23
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 22, 2020
@frankyn frankyn changed the title SAFEPATHCHARS_URLENCODER includes + fix: SAFEPATHCHARS_URLENCODER includes + Jan 22, 2020
Copy link

@frankyn frankyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified this fixes Storage issue -> googleapis/java-storage#57

@chingor13 chingor13 merged commit 9384459 into master Jan 22, 2020
@chingor13 chingor13 deleted the elharo-patch-2 branch January 22, 2020 20:25
Copy link
Contributor Author

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really? This fixed #57? That comes as a complete surprise to me. I thought this was a small no-op cleanup I'd get out of the way before looking for the real bug.

clundin25 pushed a commit to clundin25/google-http-java-client that referenced this pull request Aug 11, 2022
…als (googleapis#955)

* fix: expiration_time is only required for successful responses when an output file is specified in the credential configuration

* fix: updates PluggableAuthCredentials java docs and missing spot in README

* fix: doc fix

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
clundin25 pushed a commit to clundin25/google-http-java-client that referenced this pull request Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants