Skip to content

feat: add trace id support to JsonWriter and add default trace id to help identify json writer users. #1302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
stephaniewang526 merged 3 commits into from
Sep 8, 2021
Merged

feat: add trace id support to JsonWriter and add default trace id to help identify json writer users. #1302

stephaniewang526 merged 3 commits into from
Sep 8, 2021

Conversation

@yirutang
Copy link
Contributor

@yirutang yirutang commented Sep 8, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

@yirutang yirutang requested review from a team and loferris September 8, 2021 21:05
@product-auto-label product-auto-label bot added the api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. label Sep 8, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 8, 2021
@yirutang yirutang changed the title feat! add trace id support to JsonWriter and add default trace id to help identify json writer users. feat: add trace id support to JsonWriter and add default trace id to help identify json writer users. Sep 8, 2021
@stephaniewang526 stephaniewang526 added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 8, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 8, 2021
@stephaniewang526 stephaniewang526 merged commit 0e749d9 into googleapis:master Sep 8, 2021
@release-please release-please bot mentioned this pull request Jan 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@loferris loferris Awaiting requested review from loferris

1 more reviewer

@stephaniewang526 stephaniewang526 stephaniewang526 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yirutang @stephaniewang526