Skip to content

feat: use shared-dependencies bom and add flatten to grpc and proto m… #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
stephaniewang526 merged 1 commit into from
Apr 17, 2020
Merged

feat: use shared-dependencies bom and add flatten to grpc and proto m… #186

stephaniewang526 merged 1 commit into from
Apr 17, 2020

Conversation

@stephaniewang526
Copy link
Contributor

@stephaniewang526 stephaniewang526 commented Apr 17, 2020

  1. use shared-deps instead of a bunch of deps
  2. add flatten plugin to grpc and proto modules

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 17, 2020
@codecov
Copy link

codecov bot commented Apr 17, 2020 •
edited
Loading

Codecov Report

Merging #186 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #186   +/-   ##
=========================================
  Coverage     74.58%   74.58%           
  Complexity      344      344           
=========================================
  Files            45       45           
  Lines          2361     2361           
  Branches         82       82           
=========================================
  Hits           1761     1761           
  Misses          562      562           
  Partials         38       38

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9f8b2e...67ffcea. Read the comment docs.

chingor13
chingor13 approved these changes Apr 17, 2020
View reviewed changes
@stephaniewang526 stephaniewang526 merged commit 532a698 into googleapis:master Apr 17, 2020
shubhwip pushed a commit to shubhwip/java-bigquerystorage that referenced this pull request Oct 7, 2023
@yoshi-automation
Add cloud-RAD for Java (googleapis#186)
70b6dcf 
Co-authored-by: Jeff Ching <[email protected]>

Source-Author: Les Vogel <[email protected]>
Source-Date: Thu Jul 30 13:09:50 2020 -0700
Source-Repo: googleapis/synthtool
Source-Sha: dd230c816f88d0141fcd0be83498986287220d1b
Source-Link: googleapis/synthtool@dd230c8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chingor13 chingor13 chingor13 approved these changes

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@stephaniewang526 @chingor13 @googlebot