Skip to content

fix: add status label to gfe metrics#1077

Merged
mutianf merged 1 commit intogoogleapis:mainfrom
mutianf:refactor
Dec 1, 2021
Merged

fix: add status label to gfe metrics#1077
mutianf merged 1 commit intogoogleapis:mainfrom
mutianf:refactor

Conversation

@mutianf
Copy link
Contributor

@mutianf mutianf commented Nov 19, 2021

Refactor BigtableTracer and HeaderTracer callables to include status in the label and add Status label to the GFE metric views.

@mutianf mutianf requested a review from a team as a code owner November 19, 2021 15:41
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 19, 2021
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the googleapis/java-bigtable API. label Nov 19, 2021
Copy link
Contributor

@igorbernstein2 igorbernstein2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@mutianf mutianf merged commit 777549e into googleapis:main Dec 1, 2021
@mutianf mutianf deleted the refactor branch December 1, 2021 19:29
gcf-merge-on-green bot pushed a commit that referenced this pull request Dec 6, 2021
🤖 I have created a release \*beep\* \*boop\*
---
### [2.3.1](https://www.github.com/googleapis/java-bigtable/compare/v2.3.0...v2.3.1) (2021-12-03)


### Bug Fixes

* add placeholder class for bigtable-stats ([#1075](https://www.github.com/googleapis/java-bigtable/issues/1075)) ([9d9f575](https://www.github.com/googleapis/java-bigtable/commit/9d9f57556216becfeb302bfaf5a4f35a9b73b611))
* add status label to gfe metrics ([#1077](https://www.github.com/googleapis/java-bigtable/issues/1077)) ([777549e](https://www.github.com/googleapis/java-bigtable/commit/777549e6ac64a03c9bd67d6b5a5cf4819ba8656f))
* make placeholder class public ([#1085](https://www.github.com/googleapis/java-bigtable/issues/1085)) ([879377a](https://www.github.com/googleapis/java-bigtable/commit/879377a03b86aa9a1f1035245c290ec78501b2cd))


### Dependencies

* update dependency com.google.cloud:google-cloud-shared-dependencies to v2.5.1 ([#1087](https://www.github.com/googleapis/java-bigtable/issues/1087)) ([f290ce7](https://www.github.com/googleapis/java-bigtable/commit/f290ce74f6b803b8c5786e8b4c69b9efa6995c59))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigtable Issues related to the googleapis/java-bigtable API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants