feat: add more context to row merging errors#281
Merged
igorbernstein2 merged 3 commits intogoogleapis:masterfrom May 6, 2020
Merged
feat: add more context to row merging errors#281igorbernstein2 merged 3 commits intogoogleapis:masterfrom
igorbernstein2 merged 3 commits intogoogleapis:masterfrom
Conversation
kolea2
approved these changes
May 6, 2020
Contributor
Author
|
Should be ready now |
kolea2
approved these changes
May 6, 2020
Codecov Report
@@ Coverage Diff @@
## master #281 +/- ##
============================================
+ Coverage 79.76% 79.82% +0.06%
Complexity 991 991
============================================
Files 99 99
Lines 6399 6414 +15
Branches 319 319
============================================
+ Hits 5104 5120 +16
Misses 1098 1098
+ Partials 197 196 -1
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These errors should never happen. But if they do, it would very useful to get more context as to what rows triggered them