Skip to content
This repository was archived by the owner on Dec 3, 2023. It is now read-only.

fix: fix conversion for pre-epoch timestamps#160

Merged
chingor13 merged 3 commits intomasterfrom
fix-negative-timestamp
Feb 25, 2020
Merged

fix: fix conversion for pre-epoch timestamps#160
chingor13 merged 3 commits intomasterfrom
fix-negative-timestamp

Conversation

@chingor13
Copy link
Contributor

@chingor13 chingor13 commented Feb 19, 2020

Fixes #159

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 19, 2020
@chingor13 chingor13 force-pushed the fix-negative-timestamp branch from 0030226 to 0c32d16 Compare February 19, 2020 21:37
@codecov
Copy link

codecov bot commented Feb 19, 2020 •
edited
Loading

Codecov Report

Merging #160 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #160      +/-   ##
============================================
+ Coverage     66.54%   66.56%   +0.01%     
- Complexity      370      371       +1     
============================================
  Files            34       34              
  Lines          1877     1881       +4     
  Branches        240      241       +1     
============================================
+ Hits           1249     1252       +3     
- Misses          526      527       +1     
  Partials        102      102
Impacted Files Coverage Δ Complexity Δ
...core/src/main/java/com/google/cloud/Timestamp.java 90.62% <100%> (+0.62%) 25 <2> (+1) ⬆️
.../java/com/google/cloud/testing/CommandWrapper.java 87.87% <0%> (-9.1%) 13% <0%> (ø)
...src/main/java/com/google/cloud/ServiceOptions.java 44.26% <0%> (+0.79%) 33% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebc0e6c...b17ac48. Read the comment docs.

@chingor13 chingor13 changed the title test: failing test for parsing a negative timestamp fix: fix conversion for pre-epoch timestamps Feb 19, 2020
@chingor13 chingor13 marked this pull request as ready for review February 19, 2020 21:50
@chingor13 chingor13 requested a review from a team February 19, 2020 21:50
elharo
elharo reviewed Feb 19, 2020
View reviewed changes
elharo
elharo reviewed Feb 19, 2020
View reviewed changes
Copy link
Contributor

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, haven't we seen this problem before a few months back? maybe in a different project?

@chingor13
Copy link
Contributor Author

chingor13 commented Feb 19, 2020

also, haven't we seen this problem before a few months back? maybe in a different project?

I think this was something similar: googleapis/google-http-java-client#895

@chingor13 chingor13 merged commit 1f8b6b4 into master Feb 25, 2020
@chingor13 chingor13 deleted the fix-negative-timestamp branch February 25, 2020 18:26
gcf-merge-on-green bot pushed a commit that referenced this pull request Feb 27, 2020
@release-please
chore: release 1.93.0 (#167)
74f8632 
🤖 I have created a release \*beep\* \*boop\* 
---
## [1.93.0](https://www.github.com/googleapis/java-core/compare/v1.92.6...v1.93.0) (2020-02-27)


### Features

* support conditional policies ([#110](https://www.github.com/googleapis/java-core/issues/110)) ([61e2d19](https://www.github.com/googleapis/java-core/commit/61e2d19bb4400978681aa018a8dc200214203830))


### Bug Fixes

* fix conversion for pre-epoch timestamps ([#160](https://www.github.com/googleapis/java-core/issues/160)) ([1f8b6b4](https://www.github.com/googleapis/java-core/commit/1f8b6b4835aaa702ec94bbbde89ed90f519c935a))


### Dependencies

* update dependency com.google.api:gax-bom to v1.54.0 ([#168](https://www.github.com/googleapis/java-core/issues/168)) ([5b52f9e](https://www.github.com/googleapis/java-core/commit/5b52f9e8d8cdc82b56114d3d1e857d137ae7ca98))
* update dependency io.grpc:grpc-bom to v1.27.2 ([#166](https://www.github.com/googleapis/java-core/issues/166)) ([28c9859](https://www.github.com/googleapis/java-core/commit/28c98595c9ee96760a063085bd85024177bd6dd2))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).
@olavloite olavloite mentioned this pull request Mar 12, 2020
Merged
@release-please release-please bot mentioned this pull request Jan 4, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@elharo elharo elharo left review comments

@codyoss codyoss codyoss approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Timestamp.of(java.sql.Timestamp) off-by-one on pre-epoch dates

4 participants

@chingor13 @elharo @codyoss @googlebot