This repository was archived by the owner on Oct 2, 2023. It is now read-only.
fix: do not retry on 13 INTERNAL #396
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Committer: @miraleung PiperOrigin-RevId: 346440719 Source-Author: Google APIs <[email protected]> Source-Date: Tue Dec 8 16:57:38 2020 -0800 Source-Repo: googleapis/googleapis Source-Sha: 85a5954183479a9a7c2641c013cd728b6fa9b7cd Source-Link: googleapis/googleapis@85a5954
Committer: @miraleung PiperOrigin-RevId: 347036369 Source-Author: Google APIs <[email protected]> Source-Date: Fri Dec 11 11:13:47 2020 -0800 Source-Repo: googleapis/googleapis Source-Sha: 6d65640b1fcbdf26ea76cb720de0ac138cae9bed Source-Link: googleapis/googleapis@6d65640
Committer: @miraleung PiperOrigin-RevId: 350067652 Source-Author: Google APIs <[email protected]> Source-Date: Mon Jan 4 19:45:21 2021 -0800 Source-Repo: googleapis/googleapis Source-Sha: ad3bb00ed7750cd0625b3a36e0e2eff29f778e4a Source-Link: googleapis/googleapis@ad3bb00
Committer: @miraleung PiperOrigin-RevId: 350949863 Source-Author: Google APIs <[email protected]> Source-Date: Sat Jan 9 14:01:49 2021 -0800 Source-Repo: googleapis/googleapis Source-Sha: 91e206bcfeaf8948ea03fe3cb1b7616108496cd3 Source-Link: googleapis/googleapis@91e206b
Committer: @miraleung PiperOrigin-RevId: 351867503 Source-Author: Google APIs <[email protected]> Source-Date: Thu Jan 14 13:38:11 2021 -0800 Source-Repo: googleapis/googleapis Source-Sha: f1b2cc9c37f453c3b15e8945af32812f71634022 Source-Link: googleapis/googleapis@f1b2cc9
Fixes googleapis/nodejs-kms#375. The malformed request triggers `13 INTERNAL` from gRPC and we should not silently retry on this code. Committer: @alexander-fenster PiperOrigin-RevId: 357022763 Source-Author: Google APIs <[email protected]> Source-Date: Thu Feb 11 11:39:31 2021 -0800 Source-Repo: googleapis/googleapis Source-Sha: 3f914b89ae1ef459955f470f9ccb498314ad28d5 Source-Link: googleapis/googleapis@3f914b8
Codecov Report
@@ Coverage Diff @@
## master #396 +/- ##
=========================================
Coverage 76.81% 76.81%
Complexity 174 174
=========================================
Files 6 6
Lines 1449 1449
Branches 25 25
=========================================
Hits 1113 1113
Misses 307 307
Partials 29 29
Continue to review full report at Codecov.
|
Neenu1995
approved these changes
Feb 16, 2021
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Feb 23, 2021
🤖 I have created a release \*beep\* \*boop\* --- ### [1.40.7](https://www.github.com/googleapis/java-kms/compare/v1.40.6...v1.40.7) (2021-02-22) ### Bug Fixes * do not retry on 13 INTERNAL ([#396](https://www.github.com/googleapis/java-kms/issues/396)) ([ea2f95a](https://www.github.com/googleapis/java-kms/commit/ea2f95a02af7de0c6a867b44aa3ec31fd7a0dac2)) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v0.19.0 ([#404](https://www.github.com/googleapis/java-kms/issues/404)) ([4ab1137](https://www.github.com/googleapis/java-kms/commit/4ab113762461c079777eb617909aaf57a446f1cc)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was generated using Autosynth. 🌈
Synth log will be available here:
https://source.cloud.google.com/results/invocations/a7d32ac5-d75c-4316-9418-8435525bdb8d/targets
PiperOrigin-RevId: 357022763
Source-Link: googleapis/googleapis@3f914b8
PiperOrigin-RevId: 351867503
Source-Link: googleapis/googleapis@f1b2cc9
PiperOrigin-RevId: 350949863
Source-Link: googleapis/googleapis@91e206b
PiperOrigin-RevId: 350067652
Source-Link: googleapis/googleapis@ad3bb00
PiperOrigin-RevId: 347036369
Source-Link: googleapis/googleapis@6d65640
PiperOrigin-RevId: 346440719
Source-Link: googleapis/googleapis@85a5954
chore: migrate kms to the Java microgenerator
chore: update gapic-generator-java to 0.0.11
chore: update gapic-generator-java to 0.0.16
chore: update gapic-generator-java to 0.0.18
chore: un-migrate kms from the Java microgenerator to the monolith