docs: update comments#1188
Merged
BenWhitehead merged 2 commits intogoogleapis:mainfrom Jan 6, 2022
BenWhitehead:retry-sample-fixes
Merged
docs: update comments#1188BenWhitehead merged 2 commits intogoogleapis:mainfrom BenWhitehead:retry-sample-fixes
BenWhitehead merged 2 commits intogoogleapis:mainfrom
BenWhitehead:retry-sample-fixes
Conversation
1 task
cbonnie
reviewed
Jan 6, 2022
| StorageOptions.getDefaultRetrySettings() | ||
| .toBuilder() | ||
| // to set the max number of attempts to 10 | ||
| // Set the max number of attempts to 10 (initial attempt plus 9 retries) |
Collaborator
There was a problem hiding this comment.
I think this part can just be "(default=1)" to show that the default number of attempts is 1.
Collaborator
Author
There was a problem hiding this comment.
The default number of attempts is 6, so that'd be 5 retries.
cbonnie
approved these changes
Jan 6, 2022
samples/snippets/src/main/java/com/example/storage/ConfigureRetries.java
Outdated
Show resolved
Hide resolved
cojenco
approved these changes
Jan 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comment fixes from review after merge of #1152