feat: expose all the methods of notification#141
Conversation
Codecov Report
@@ Coverage Diff @@
## master #141 +/- ##
============================================
+ Coverage 63.13% 63.61% +0.48%
- Complexity 601 632 +31
============================================
Files 32 33 +1
Lines 5078 5222 +144
Branches 481 498 +17
============================================
+ Hits 3206 3322 +116
- Misses 1708 1730 +22
- Partials 164 170 +6
Continue to review full report at Codecov.
|
frankyn
left a comment
There was a problem hiding this comment.
Please don't rely on PubSub in Notification support.
google-cloud-storage/pom.xml
Outdated
| </dependency> | ||
| <dependency> | ||
| <groupId>com.google.cloud</groupId> | ||
| <artifactId>google-cloud-pubsub</artifactId> |
There was a problem hiding this comment.
Don't rely on pubsub in this case please.
|
There's a linkage issue: |
|
@frankyn here we cant do anything to fix this issue,we can fix it in java-storage-nio. I have already raised the issue over there you can see here storage-nio-38. |
|
@frankyn here, how we can move ahead with above situation? |
|
@athakor could you merge master and resolve conflicts? |
…ix the builds checks
|
Thanks, we need one more release of the libraries-bom. Should be coming soon and wanted to prep to have your pr ready. |
|
@frankyn thanks for your quick response. |
|
whoops, didn't mean to close. libraries-bom released and rerunning tests. |
Fixes #138
This PR exposing all the methods of notifications, also contain the unit test as well as system test of each method.