Skip to content

Conversation

@frankyn
Copy link
Contributor

@frankyn frankyn commented Apr 14, 2020

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 14, 2020
@frankyn frankyn added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 14, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 14, 2020
@frankyn frankyn requested a review from JesseLovelace April 14, 2020 22:07
@codecov
Copy link

codecov bot commented Apr 14, 2020

Codecov Report

Merging #248 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #248   +/-   ##
=========================================
  Coverage     63.52%   63.52%           
  Complexity      540      540           
=========================================
  Files            30       30           
  Lines          4776     4776           
  Branches        431      431           
=========================================
  Hits           3034     3034           
  Misses         1580     1580           
  Partials        162      162           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebab7e6...85d437b. Read the comment docs.

<groupId>com.google.api.grpc</groupId>
<artifactId>grpc-google-cloud-kms-v1</artifactId>
<version>0.85.0</version>
<version>0.83.1</version>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why two versions back?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I accidentally merged -> #223 and related PRs when I shouldn't have.

@frankyn frankyn merged commit 0f6703e into master Apr 14, 2020
@frankyn frankyn deleted the revert-grpc-update-2 branch April 14, 2020 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants