feat: add support of daysSinceNoncurrentTime and noncurrentTimeBefore OLM options#335
feat: add support of daysSinceNoncurrentTime and noncurrentTimeBefore OLM options#335frankyn merged 5 commits intogoogleapis:masterfrom
Conversation
frankyn
left a comment
There was a problem hiding this comment.
Thanks @athakor, added @JesseLovelace as well.
Linkage monitor failure needs to be addressed and request for method documentation.
google-cloud-storage/src/main/java/com/google/cloud/storage/BucketInfo.java
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #335 +/- ##
============================================
+ Coverage 63.29% 63.66% +0.36%
Complexity 613 613
============================================
Files 32 32
Lines 5144 5166 +22
Branches 492 495 +3
============================================
+ Hits 3256 3289 +33
+ Misses 1724 1718 -6
+ Partials 164 159 -5
Continue to review full report at Codecov.
|
@frankyn done PTAL |
|
We are still blocked and pending approval to move forward from @jkwlui |
frankyn
left a comment
There was a problem hiding this comment.
Hi @athakor,
Update: The Cloud Storage team has updated type of noncurrent_time_before and custom_time to be a Date format (YYYY-mm-dd) instead of DateTime.
Discovery document with updated documentation with respect to these fields:
https://www.googleapis.com/discovery/v1/apis/storage/v1/rest
This has been updated in the latest release dependency in PR (#457). Please update relevant documentation.
@frankyn That change has been already done also updated the relevant java doc. |
|
@jkwlui @JesseLovelace PTAL |
Fixes #332