fix: PostPolicyV4.PostFieldsV4.Builder.addCustomMetadataField() allows to add prefixed an not prefixed custom fields#398
Merged
frankyn merged 7 commits intogoogleapis:masterfrom Jul 14, 2020
Conversation
Codecov Report
@@ Coverage Diff @@
## master #398 +/- ##
============================================
- Coverage 63.27% 63.22% -0.05%
Complexity 609 609
============================================
Files 32 32
Lines 5113 5117 +4
Branches 487 488 +1
============================================
Hits 3235 3235
- Misses 1713 1717 +4
Partials 165 165
Continue to review full report at Codecov.
|
frankyn
reviewed
Jul 1, 2020
| return addCustomMetadataField(field, value); | ||
| } | ||
|
|
||
| public Builder addCustomMetadataField(String field, String value) { |
frankyn
approved these changes
Jul 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #394