Skip to content

fix: PostPolicyV4.PostFieldsV4.Builder.addCustomMetadataField() allows to add prefixed an not prefixed custom fields #398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
frankyn merged 7 commits into from
Jul 14, 2020
Merged

fix: PostPolicyV4.PostFieldsV4.Builder.addCustomMetadataField() allows to add prefixed an not prefixed custom fields #398

frankyn merged 7 commits into from
Jul 14, 2020

Conversation

@dmitry-fa
Copy link
Contributor

@dmitry-fa dmitry-fa commented Jun 29, 2020

Fixes #394

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 29, 2020
@codecov
Copy link

codecov bot commented Jun 29, 2020 •
edited
Loading

Codecov Report

Merging #398 into master will decrease coverage by 0.04%.
The diff coverage is 16.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #398      +/-   ##
============================================
- Coverage     63.27%   63.22%   -0.05%     
  Complexity      609      609              
============================================
  Files            32       32              
  Lines          5113     5117       +4     
  Branches        487      488       +1     
============================================
  Hits           3235     3235              
- Misses         1713     1717       +4     
  Partials        165      165
Impacted Files Coverage Δ Complexity Δ
...in/java/com/google/cloud/storage/PostPolicyV4.java 62.66% <16.66%> (-1.72%) 4.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12bd62c...45214ca. Read the comment docs.

frankyn
frankyn reviewed Jul 1, 2020
View reviewed changes
google-cloud-storage/src/main/java/com/google/cloud/storage/PostPolicyV4.java Outdated
return addCustomMetadataField(field, value);
}

public Builder addCustomMetadataField(String field, String value) {
Copy link
Contributor

@frankyn frankyn Jul 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use setCustomMetadataField

Copy link
Contributor Author

@dmitry-fa dmitry-fa Jul 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@frankyn
done

Copy link
Contributor Author

@dmitry-fa dmitry-fa Jul 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@frankyn: gentle ping

@dmitry-fa dmitry-fa added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 1, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 1, 2020
@dmitry-fa dmitry-fa added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 13, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 13, 2020
@dmitry-fa dmitry-fa requested a review from frankyn July 13, 2020 15:44
@dmitry-fa dmitry-fa added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 14, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 14, 2020
@frankyn frankyn merged commit 02dc3b5 into googleapis:master Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JesseLovelace JesseLovelace Awaiting requested review from JesseLovelace

1 more reviewer

@frankyn frankyn frankyn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support: Accept x-goog-meta-* as metadata value in PostPolicyV4

4 participants

@dmitry-fa @frankyn @googlebot @yoshi-kokoro