fix: PostPolicyV4 classes could be improved

[dmitry-fa]

Fixes #440

(new tests will be suggested in a separate PR)

[codecov]

Codecov Report

Merging #442 into master will increase coverage by 0.95%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #442      +/-   ##
============================================
+ Coverage     63.17%   64.12%   +0.95%     
- Complexity      619      623       +4     
============================================
  Files            32       32              
  Lines          5133     5177      +44     
  Branches        489      498       +9     
============================================
+ Hits           3243     3320      +77     
+ Misses         1726     1693      -33     
  Partials        164      164              

Impacted Files	Coverage Δ	Complexity Δ
...rc/main/java/com/google/cloud/storage/Storage.java	80.64% <ø> (ø)	0.00 <0.00> (ø)
...in/java/com/google/cloud/storage/PostPolicyV4.java	86.33% <100.00%> (+23.67%)	5.00 <0.00> (+1.00)
...src/main/java/com/google/cloud/storage/Bucket.java	82.20% <0.00%> (+0.12%)	34.00% <0.00%> (ø%)
...ain/java/com/google/cloud/storage/StorageImpl.java	81.25% <0.00%> (+0.24%)	147.00% <0.00%> (ø%)
...main/java/com/google/cloud/storage/BucketInfo.java	82.01% <0.00%> (+0.27%)	86.00% <0.00%> (+3.00%)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8a4b12...b5a4f90. Read the comment docs.

[elharo]

Tests should be written before the model code and absolutely in the same PR.

[dmitry-fa]

@elharo
The issue for new tests: #410

The model code was integrated without proper coverage by tests. For the time being it's covered by 10 conformance tests. This just adds javadoc and fixes minor bugs found.

Before developing new tests I'd like to get feedback on the proposed changes.

[elharo]

Comment changes don't need tests but this PR changes behavior. Every behavioral change should be proceeded by a test that fails and only passes after the model code is added.

[dmitry-fa]

@elharo

Comment changes don't need tests but this PR changes behavior. Every behavioral change should be proceeded by a test that fails and only passes after the model code is added.

All the tests have been developed. Will much appreciate if you take a look.

[elharo]

What URLs do you really want to allow and not allow here? java.net.URL is based on java protocol handlers, and is likely to be either too lenient or too strict depending on what you need.

[dmitry-fa]

I want to allow strings that could be used to construct an URL object and reject strings like 'google.com' given by mistake instead of 'https://google.com'. Catching 'ftp://google.com' is not the goal.

[elharo]

sounds like new URI(url).isAbsolute() is your best bet then

[dmitry-fa]

agree, fixed.