fix: When passing a sub-array (offset, length) to the Storage#create method the array is needlessly cloned

[benbenw]

leading to unnecessary memory allocations.

No new tests as it was already covered.

Signed-off-by: benoit [email protected]

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

• Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
• Ensure the tests and linter pass
• Code coverage does not decrease (if any source code was changed)
• Appropriate docs were updated (if necessary)

Fixes #505 ☕️

[google-cla]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

[codecov]

Codecov Report

Merging #506 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #506      +/-   ##
============================================
+ Coverage     64.69%   64.71%   +0.02%     
+ Complexity      629      620       -9     
============================================
  Files            32       32              
  Lines          5249     5252       +3     
  Branches        509      510       +1     
============================================
+ Hits           3396     3399       +3     
  Misses         1694     1694              
  Partials        159      159              

Impacted Files	Coverage Δ	Complexity Δ
...ain/java/com/google/cloud/storage/StorageImpl.java	81.31% <100.00%> (+0.06%)	138.00 <0.00> (-9.00)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10cc743...25197b3. Read the comment docs.

[benbenw]

@googlebot I signed it!

[frankyn]

Thanks @benbenw, pending CI passing and then it should merge.