Skip to content
This repository was archived by the owner on Nov 9, 2024. It is now read-only.

Conversation

@ikuleshov
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@ikuleshov ikuleshov requested a review from a team as a code owner September 24, 2020 03:21
@ikuleshov ikuleshov requested review from dinagraves and removed request for a team September 24, 2020 03:21
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 24, 2020
@product-auto-label product-auto-label bot added api: analyticsdata Issues related to the googleapis/python-analytics-data API. samples Issues that are directly related to samples. labels Sep 24, 2020
@dinagraves dinagraves added the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 6, 2020
@busunkim96 busunkim96 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 6, 2020
@dinagraves dinagraves removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 6, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 6, 2020
@dinagraves dinagraves added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 7, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 7, 2020
@ikuleshov ikuleshov added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 7, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 7, 2020
Copy link
Contributor

@dinagraves dinagraves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval granted, pending Lint fixes.

@ikuleshov ikuleshov merged commit a4bcc31 into googleapis:master Oct 7, 2020
gcf-merge-on-green bot pushed a commit that referenced this pull request Nov 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: analyticsdata Issues related to the googleapis/python-analytics-data API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants