Skip to content

Fix: Add DECIMAL and BIGDECIMAL as aliases for NUMERIC and BIGNUMERIC #638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tswast merged 5 commits into from
Apr 29, 2021
Merged

Fix: Add DECIMAL and BIGDECIMAL as aliases for NUMERIC and BIGNUMERIC #638

tswast merged 5 commits into from
Apr 29, 2021

Conversation

@jimfulton
Copy link
Contributor

@jimfulton jimfulton commented Apr 29, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #626 🦕

Jim Fulton added 5 commits April 28, 2021 13:28
Added decimal types to SqlTypeNames and SqlParameterScalarTypes
9ca477e
Merge remote-tracking branch 'origin/master' into riversnake-626
534ab0e
Go ahead and alias on the client
8e8ac82 
To convey to the observant that these are aliases, even though they could be used (more or less) directly.
Make sure that DECIMAL data are converted when making API calls.
65bd47b 
This is mainly as a backstop -- DECIMAL requests should be converted to NUMERIC.
blacken
1497c97
@jimfulton jimfulton requested a review from a team April 29, 2021 14:58
@jimfulton jimfulton requested a review from a team as a code owner April 29, 2021 14:58
@jimfulton jimfulton requested review from stephaniewang526 and removed request for a team April 29, 2021 14:58
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Apr 29, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Apr 29, 2021
@jimfulton jimfulton added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Apr 29, 2021
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Apr 29, 2021
@jimfulton jimfulton added the release blocking Required feature/issue must be fixed prior to next release. label Apr 29, 2021
@tswast tswast merged commit aa59023 into master Apr 29, 2021
@tswast tswast deleted the riversnake-626 branch April 29, 2021 16:35
gcf-merge-on-green bot pushed a commit that referenced this pull request Apr 29, 2021
@release-please
chore: release 2.15.0 (#637)
6e6cfdf 
🤖 I have created a release \*beep\* \*boop\*
---
## [2.15.0](https://www.github.com/googleapis/python-bigquery/compare/v2.14.0...v2.15.0) (2021-04-29)


### Features

* Extended DB API parameter syntax to optionally provide parameter types ([#626](https://www.github.com/googleapis/python-bigquery/issues/626)) ([8bcf397](https://www.github.com/googleapis/python-bigquery/commit/8bcf397fbe2527e06317741875a059b109cfcd9c))


### Bug Fixes

* add DECIMAL and BIGDECIMAL as aliases for NUMERIC and BIGNUMERIC ([#638](https://www.github.com/googleapis/python-bigquery/issues/638)) ([aa59023](https://www.github.com/googleapis/python-bigquery/commit/aa59023317b1c63720fb717b3544f755652da58d))
* The DB API Binary function accepts bytes data ([#630](https://www.github.com/googleapis/python-bigquery/issues/630)) ([4396e70](https://www.github.com/googleapis/python-bigquery/commit/4396e70771af6889d3242c37c5ff2e80241023a2))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@tswast tswast mentioned this pull request Apr 30, 2021
Closed
@release-please release-please bot mentioned this pull request Jan 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tswast tswast tswast approved these changes

@stephaniewang526 stephaniewang526 Awaiting requested review from stephaniewang526

Assignees

No one assigned

Labels

api: bigquery Issues related to the googleapis/python-bigquery API. cla: yes This human has signed the Contributor License Agreement. release blocking Required feature/issue must be fixed prior to next release.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jimfulton @tswast @yoshi-kokoro