Skip to content

fix: harden version data gathering against DistributionNotFound #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
crwilcox merged 1 commit into from
Oct 6, 2020
Merged

fix: harden version data gathering against DistributionNotFound #150

crwilcox merged 1 commit into from
Oct 6, 2020

Conversation

@crwilcox
Copy link
Contributor

@crwilcox crwilcox commented Oct 6, 2020

No description provided.

@crwilcox crwilcox requested review from busunkim96 and kolea2 October 6, 2020 19:49
@crwilcox crwilcox requested a review from a team as a code owner October 6, 2020 19:49
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 6, 2020
@crwilcox crwilcox merged commit c815421 into master Oct 6, 2020
@tseaver tseaver mentioned this pull request Nov 11, 2020
Closed
1 task
tseaver added a commit that referenced this pull request Nov 11, 2020
@tseaver
chore: clean up synth replacements
f6bead6 
- Remove those which no longer match.
- Apply '_GAPIC_LIBRARY_VERSION' tweak from PR #150.

Closes #155.
Closes #156.
@tseaver tseaver mentioned this pull request Nov 11, 2020
Merged
crwilcox pushed a commit that referenced this pull request Nov 11, 2020
@tseaver
chore: clean up synth replacements (#161)
ff3c577 
- Remove those which no longer match.
- Apply '_GAPIC_LIBRARY_VERSION' tweak from PR #150.

Closes #155.
Closes #156.
@tseaver tseaver mentioned this pull request Nov 12, 2020
Merged
@tseaver tseaver deleted the guard-get-distribution branch September 22, 2021 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kolea2 kolea2 kolea2 approved these changes

+1 more reviewer

@busunkim96 busunkim96 busunkim96 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@crwilcox @busunkim96 @kolea2