Skip to content

docs: update links to reflect new Github org #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tseaver merged 7 commits into from
Aug 3, 2020
Merged

docs: update links to reflect new Github org #48

tseaver merged 7 commits into from
Aug 3, 2020

Conversation

@HemangChothani
Copy link
Contributor

@HemangChothani HemangChothani commented Jun 2, 2020

Fixes #41

@HemangChothani HemangChothani requested review from crwilcox and kolea2 June 2, 2020 08:31
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 2, 2020
kolea2
kolea2 reviewed Jun 5, 2020
View reviewed changes
docs/client-intro.rst Outdated

.. _Instance Admin: https://github.com/GoogleCloudPlatform/cloud-bigtable-client/tree/master/bigtable-protos/src/main/proto/google/bigtable/admin/instance/v1
.. _Table Admin: https://github.com/GoogleCloudPlatform/cloud-bigtable-client/tree/master/bigtable-protos/src/main/proto/google/bigtable/admin/table/v1
.. _Instance Admin: https://github.com/googleapis/java-bigtable/tree/master/proto-google-cloud-bigtable-admin-v2/src/main/proto/google/bigtable/admin/v2
Copy link
Collaborator

@kolea2 kolea2 Jun 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should these link to code in python-bigtable? For example, https://github.com/googleapis/python-bigtable/blob/master/google/cloud/bigtable_admin_v2/proto/bigtable_table_admin.proto?

Copy link
Contributor Author

@HemangChothani HemangChothani Jun 8, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kolea2 Yes, I have also doubt about the links but when i have checked links which is in data-api.rst file they have redirected to the java-hbase and the older link, also i have found related of google-jcloud-ava. If you are sure about those links then i will change all the links which redirect to the python relatable content.

Copy link
Contributor

@crwilcox crwilcox Jun 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. Should be pointing to protos in the python library.

@tseaver
Copy link
Contributor

tseaver commented Aug 3, 2020

Systets and snippets failures due to leaked nodes exceeding quota.

@tseaver tseaver changed the title docs(bigtable): replace bad links to the new links docs: update links to reflect new Github org Aug 3, 2020
@tseaver tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 3, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 3, 2020
@tseaver tseaver merged commit 9bb11ed into googleapis:master Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kolea2 kolea2 kolea2 approved these changes

@crwilcox crwilcox Awaiting requested review from crwilcox

+1 more reviewer

@tseaver tseaver tseaver approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Documentation: Bad links in docs

6 participants

@HemangChothani @tseaver @crwilcox @kolea2 @googlebot @yoshi-kokoro