Skip to content

feat: Improve source location overrides #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
daniel-sanche merged 11 commits into from
Apr 20, 2021
Merged

feat: Improve source location overrides #258

daniel-sanche merged 11 commits into from
Apr 20, 2021

Conversation

@daniel-sanche
Copy link
Contributor

@daniel-sanche daniel-sanche commented Apr 15, 2021 •
edited
Loading

  • I improved how source_entries are handled in the CloudLoggingFilter, to better match the LogEntry spec
  • I added a bunch of tests around user overrides for http_request, trace, resource, and source_location fields

@daniel-sanche daniel-sanche requested review from a team as code owners April 15, 2021 21:05
@product-auto-label product-auto-label bot added the api: logging Issues related to the googleapis/python-logging API. label Apr 15, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Apr 15, 2021
@daniel-sanche daniel-sanche added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 15, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 15, 2021
@daniel-sanche daniel-sanche changed the base branch from master to v2_update_2 April 15, 2021 22:52
@daniel-sanche daniel-sanche changed the title DRAFT: Improve source location feat: Improve source location overrides Apr 16, 2021
simonz130
simonz130 reviewed Apr 20, 2021
View reviewed changes
@daniel-sanche daniel-sanche merged commit 6b10b74 into v2_update_2 Apr 20, 2021
@daniel-sanche daniel-sanche deleted the improve-source-location branch April 20, 2021 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@simonz130 simonz130 simonz130 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@daniel-sanche daniel-sanche

Labels

api: logging Issues related to the googleapis/python-logging API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@daniel-sanche @simonz130 @yoshi-kokoro