Skip to content

fix: Remove Future type hint from return type which fails to type check when overridden#133

Merged
dpcollins-google merged 1 commit intomasterfrom
fix-type-hint
May 5, 2021
Merged

fix: Remove Future type hint from return type which fails to type check when overridden#133
dpcollins-google merged 1 commit intomasterfrom
fix-type-hint

Conversation

@dpcollins-google
Copy link
Collaborator

@dpcollins-google dpcollins-google commented May 5, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #132 🦕

@dpcollins-google dpcollins-google requested a review from a team as a code owner May 5, 2021 17:59
@product-auto-label product-auto-label bot added the api: pubsublite Issues related to the googleapis/python-pubsublite API. label May 5, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label May 5, 2021
@anguillanneuf
Copy link
Collaborator

Thank you! This will fix #127, #128, #129, #130, #131 after the next release too.

@dpcollins-google dpcollins-google merged commit abe9b14 into master May 5, 2021
@dpcollins-google dpcollins-google deleted the fix-type-hint branch May 5, 2021 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: pubsublite Issues related to the googleapis/python-pubsublite API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error when importing PublisherClient

2 participants